Skip to content

[AMD] Bump MoRI to f7e6ac6 to fix ROCm install_dependency build break#31406

Merged
HaiShaw merged 2 commits into
mainfrom
amd_fix_install_0716
Jul 16, 2026
Merged

[AMD] Bump MoRI to f7e6ac6 to fix ROCm install_dependency build break#31406
HaiShaw merged 2 commits into
mainfrom
amd_fix_install_0716

Conversation

@yctseng0211

@yctseng0211 yctseng0211 commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Motivation

The AMD PR Test (AMD) Install dependencies step is broken on main. It started failing after MoRI was bumped in docker/rocm.Dockerfile.

/sgl-workspace/mori/src/cco/cco_init.cpp:95:48: error: use of undeclared identifier 'hipMemAllocationTypeUncached'; did you mean 'hipMemAllocationTypeInvalid'?

hipMemAllocationTypeUncached (0x40000000) was only added to HIP on 2025-09-11 (ROCm/hip@642cd90) and is not present in the HIP headers of the currently pinned rocm700 CI image, so the MoRI build fails → Install dependencies exits 1.

MoRI has since landed a hotfix commit (f7e6ac6) that makes the cco module build against this ROCm version.

Modifications

Speed Tests and Profiling

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

CI States

Latest PR Test (Base): ✅ Run #29474624471
Latest PR Test (Extra): ❌ Run #29474624401

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions github-actions Bot added the amd label Jul 16, 2026
@yctseng0211

yctseng0211 commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator Author

@yctseng0211 yctseng0211 marked this pull request as ready for review July 16, 2026 03:26
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@jhchouuu

Copy link
Copy Markdown
Contributor

Hi @yctseng0211, we will fix this issue through this PR ROCm/mori#480
cc @Duyi-Wang @AMD-yanfeiwang

@yctseng0211

Copy link
Copy Markdown
Collaborator Author

Hi @yctseng0211, we will fix this issue through this PR ROCm/mori#480 cc @Duyi-Wang @AMD-yanfeiwang

@jhchouuu thanks a lot, I see the PR is merged, can I verify if it works right now ?

@jhchouuu

jhchouuu commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Hi @yctseng0211, we will fix this issue through this PR ROCm/mori#480 cc @Duyi-Wang @AMD-yanfeiwang

@jhchouuu thanks a lot, I see the PR is merged, can I verify if it works right now ?

Hi @yctseng0211 Yes, I think so. Sorry for not take ROCm 7.0.0 compatibility.

@yctseng0211 yctseng0211 changed the title [AMD] Revert MORI_COMMIT pin to e31d426 to fix install_dependency build break [AMD] WIP - Revert MORI_COMMIT pin to e31d426 to fix install_dependency build break Jul 16, 2026
@yctseng0211

yctseng0211 commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator Author

https://github.com/sgl-project/sglang/actions/runs/29474670674
triggered based on the latest mori commit f7e6ac6863c53821bc7afb91a578cc6ce38fcad0
image

the breakage in the install dependency stage is resolved, thanks @jhchouuu

cc: @HaiShaw

@yctseng0211 yctseng0211 changed the title [AMD] WIP - Revert MORI_COMMIT pin to e31d426 to fix install_dependency build break [AMD] Bump MoRI to f7e6ac6 to fix ROCm install_dependency build break Jul 16, 2026
@HaiShaw HaiShaw merged commit 8c5e0ce into main Jul 16, 2026
131 of 137 checks passed
@HaiShaw HaiShaw deleted the amd_fix_install_0716 branch July 16, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants