Include request and headers object in the payload in lib/logstasher/rails_ext/action_controller/metal/instrumentation.rb - #189
Open
gmiklos-ltg wants to merge 1 commit into
Conversation
…ion.action_controller these fields are always present according to the Rails guides..
kiss90benedek
approved these changes
Nov 5, 2025
kiss90benedek
left a comment
kiss90benedek
left a comment
There was a problem hiding this comment.
This is the same as #185. @shadabahmed any objections to merge & release this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
We noticed that these two keys are missing from the payload and broke the actionpack OpenTelemetry instrumentation because it couldn't access the request object.
According to the guides here for 6.1 (which we are using) it should be present in the hash:
https://guides.rubyonrails.org/v6.1/active_support_instrumentation.html#process-action-action-controller