Fix specs kwargs - #192
Open
skunkworker wants to merge 114 commits into
Open
Conversation
This puts all of the rails integration logic into the railtie. Some of the defaults were also changed. Parameters are logged by default, but in JSON format. Standard logging is no longer silenced by default.
The internal params were not getting cleared from the final params hash
Rather than spin through all the log subscribers and figure out how to unsubscribe them, we just include a module that re-defines the subscribers logger method to point to a silent logger.
Simply including a module does not override methods already defined on the class.
Config value named metadata to be part of payload
Add support for stdout device
If you set LogStasher.metadata, it will be appended to the message with a :metadata field before calling #to_json. You can also supply a :as_logstash_event if you wish for your payload to be wrapped in a LogStash::Event class that adds version and timestamp fields ready to be consumed by logstash/ elasticsearch. With this, we were able to clean up the log_subscriber code.
Add a new #log_as_json method to make it easy to log json messages
logstasher: add option to not touch log file.
Merge metadata into LogStash::Event types
added load_from_config to make configuration simpler
Add optional dry-validation contract support
Formats the dry-validation payload with symbolized keys and .to_json values. Also corrects .deep_merge! call to .merge!
Format dry-validation payload
Allows for type coercion via the dry-validation contract if defined.
Add support for type coercion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.