Vulkan pipeline cache: finish preload state before profile-mismatch early return#4106
Open
collinmcg wants to merge 1 commit intoshadps4-emu:mainfrom
Open
Vulkan pipeline cache: finish preload state before profile-mismatch early return#4106collinmcg wants to merge 1 commit intoshadps4-emu:mainfrom
collinmcg wants to merge 1 commit intoshadps4-emu:mainfrom
Conversation
Contributor
|
What's the point of save an incompatible cache? Explain in practical terms. |
Author
|
It doesn’t save incompatible cache for use; it lets newly rebuilt compatible cache actually get written after a mismatch so later runs are smoother instead of recompiling again. |
Contributor
|
I looked through the code in more detail, oddly enough, your edit makes sense, but not for the reasons you indicated, the AI is simply lying to you. |
Contributor
|
|
Author
|
That's what I get for intervening I guess |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a cache lifecycle edge case in
PipelineCache::WarmUp().If the stored pipeline profile doesn't match the current system profile, we currently return early. In archive mode that leaves cache DB state in preload/read-only mode for the rest of the run, while runtime registration paths can still call
DataBase::Save(...).The change is just:
Storage::DataBase::Instance().FinishPreload()in the mismatch branchSo this is not changing compatibility logic, only cleaning up DB state before continuing.
Validation on my side:
WarmUp()toRegisterShader*/RegisterPipelineDatasave pathsexternals/openal-soft) in this environment