WIP: Buffer cache: run LRU GC pass when memory threshold is exceeded#4107
Draft
collinmcg wants to merge 3 commits intoshadps4-emu:mainfrom
Draft
WIP: Buffer cache: run LRU GC pass when memory threshold is exceeded#4107collinmcg wants to merge 3 commits intoshadps4-emu:mainfrom
collinmcg wants to merge 3 commits intoshadps4-emu:mainfrom
Conversation
Contributor
|
Now run tests without using AI on real games and look for differences and regressions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While checking stutter-related paths, I noticed
BufferCache::RunGarbageCollector()was effectively a no-op under pressure.It calculated thresholds and built a cleanup lambda, but never actually walked the LRU list, so nothing got reclaimed.
This patch does the minimal thing:
lru_cache.ForEachItemBelow(gc_tick - ticks_to_destroy, clean_up)boolso we can stop aftermax_deletionsNo refactor or behavior changes outside this GC path.
Validation:
Rasterizer::OnSubmit()toRunGarbageCollector()externals/openal-soft) in this environmentbuffer_cache.cpp)