texture_cache: Handle image overlap when guest_size differs with same resource levels#4135
Open
psabhishek26 wants to merge 1 commit intoshadps4-emu:mainfrom
Open
texture_cache: Handle image overlap when guest_size differs with same resource levels#4135psabhishek26 wants to merge 1 commit intoshadps4-emu:mainfrom
psabhishek26 wants to merge 1 commit intoshadps4-emu:mainfrom
Conversation
… resource levels Fixes a crash (UNREACHABLE) in ResolveOverlap when the guest requests an image at the same address with the same format, tile mode, and dimensions, but with a different array layer count that results in a larger guest_size while having fewer or equal mip levels. When the new image has a larger guest_size, the cached image is now unconditionally freed since it is definitively superseded. When the cached image is larger or equal, it is reused as a compatible view source. Signed-off-by: psabhishek26 <sploitpay.aosp.test@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a crash (UNREACHABLE) in ResolveOverlap when the guest requests an image at the same address with the same format, tile mode, and dimensions, but with a different array layer count that results in a larger guest_size while having fewer or equal mip levels.
When the new image has a larger guest_size, the cached image is now unconditionally freed since it is definitively superseded. When the cached image is larger or equal, it is reused as a compatible view source.
Tested with Red Dead Redemption CUSA36843