Skip to content

VUID-vkCmdDraw-None-06887 #4204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kravickas wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

VUID-vkCmdDraw-None-06887 #4204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/video_core/renderer_vulkan/vk_rasterizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,9 +889,14 @@ RenderState Rasterizer::BeginRendering(const GraphicsPipeline* pipeline) {
ASSERT(desc.view_info.range.extent.levels == 1 && !image.binding.needs_rebind);

const bool has_stencil = image.info.props.has_stencil;
// Stencil writes can be enabled while depth writes are off.
const bool stencil_write =
has_stencil && regs.depth_control.stencil_enable && !desc.view_info.is_storage;
const auto new_layout = desc.view_info.is_storage
? has_stencil ? vk::ImageLayout::eDepthStencilAttachmentOptimal
: vk::ImageLayout::eDepthAttachmentOptimal
: stencil_write
? vk::ImageLayout::eDepthReadOnlyStencilAttachmentOptimal
: has_stencil ? vk::ImageLayout::eDepthStencilReadOnlyOptimal
: vk::ImageLayout::eDepthReadOnlyOptimal;
image.Transit(new_layout,
Expand Down
Loading