Skip to content

For OpImageFetch, do not provide both Lod and Sample operands #4210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mikusp wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Draft

For OpImageFetch, do not provide both Lod and Sample operands #4210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/shader_recompiler/backend/spirv/emit_spirv_image.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,12 @@ Id EmitImageRead(EmitContext& ctx, IR::Inst* inst, u32 handle, Id coords, Id lod
Id texel;
if (!texture.is_storage) {
const Id image = ctx.OpLoad(texture.image_type, texture.id);
operands.Add(spv::ImageOperandsMask::Lod, lod);
if (texture.view_type != AmdGpu::ImageType::Color2DMsaa) {
if (Sirit::ValidId(ms)) {
LOG_ERROR(Render_Recompiler, "image is not MS but ms operand is provided");
}
operands.Add(spv::ImageOperandsMask::Lod, lod);
}
texel = ctx.OpImageFetch(color_type, image, coords, operands.mask, operands.operands);
} else {
Id image_ptr = texture.id;
Expand Down
2 changes: 1 addition & 1 deletion src/shader_recompiler/ir/passes/resource_tracking_pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,7 +1051,7 @@ void PatchImageSampleArgs(IR::Block& block, IR::Inst& inst, Info& info,

auto texel = [&] -> IR::Value {
if (is_msaa) {
return ir.ImageRead(handle, coords, ir.Imm32(0U), ir.Imm32(0U), inst_info);
return ir.ImageRead(handle, coords, {}, ir.Imm32(0U), inst_info);
}
if (inst_info.is_gather) {
if (inst_info.is_depth) {
Expand Down
Loading