Replace global/singletons by a single ShadPs4 singleton to reduce all…#4220
Draft
Niram7777 wants to merge 1 commit intoshadps4-emu:mainfrom
Draft
Replace global/singletons by a single ShadPs4 singleton to reduce all…#4220Niram7777 wants to merge 1 commit intoshadps4-emu:mainfrom
Niram7777 wants to merge 1 commit intoshadps4-emu:mainfrom
Conversation
… scope inside main and control order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… scope inside main and control order
This removes the
quick_exitThis is working when closing the SDL window early (when the
linker->main_threadis not really far)This change requires to use
ShadPs4App::GetInstance()now (except insideLibraries::HleLayerconstructor where Dependency Injection is required, pass parameters through constructor)