Skip to content

Query Caching Bug Fix #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
schirner wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Query Caching Bug Fix #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
870b4ac
changed call to loadTable to load individual table (instead of all ta…
schirner Mar 19, 2018
b2a83d8
changed view name to include original table name to enable table look…
schirner Mar 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dataface/DB.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,7 @@ function getTableDependencies($sql, $lang=null){
if ( preg_match('/^dataface__view_(.*)_[a-z0-9]{32}$/', $table, $matches) ){
$tables[$tid] = $table = $matches[1];
}
$tobj =& Dataface_Table::loadTable($table,null,true);
$tobj =& Dataface_Table::loadTable($table);
if ( is_a($tobj, 'Dataface_Table') and isset($tobj->_atts['__dependencies__']) ){
$deps = array_map('trim', explode(',', $tobj->_atts['__dependencies__']));
$tables = array_merge($tables, $deps);
Expand Down
2 changes: 1 addition & 1 deletion Dataface/Table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1828,7 +1828,7 @@ function getProxyView(){
return null;
}
$sqlKey = md5($sql);
$viewName = 'dataface__view_'.md5($this->tablename.'_'.$sqlKey);
$viewName = 'dataface__view_'.$this->tablename.'_'.$sqlKey;
if ( isset($this->_proxyViews[$viewName]) and $this->_proxyViews[$viewName]) return $viewName;
else if ( isset($this->_proxyViews[$viewName]) and !$this->_proxyViews[$viewName]) return null;

Expand Down