fix: normalize exclude patterns in build_overrides #1926
Open
FidelSch wants to merge 1 commit intosharkdp:masterfrom
Open
fix: normalize exclude patterns in build_overrides #1926FidelSch wants to merge 1 commit intosharkdp:masterfrom
FidelSch wants to merge 1 commit intosharkdp:masterfrom
Conversation
tmccombs
requested changes
Mar 17, 2026
| // Always make such patterns unanchored with a "**/" prefix. | ||
| let glob = &pattern[1..]; // strip leading "!" | ||
| let normalized = if glob.contains('/') && !glob.starts_with("**/") { | ||
| format!("!**/{}", glob) |
Collaborator
There was a problem hiding this comment.
This will significantly change the behavior. That means that if you exclude something like "/a/b" that will now start also excluding
"foo/a/b" from the base directory.
I'll put some more thoughts on how we could approach solving this on the issue itself, but I don't thik this is a good solution for this.
Contributor
Author
There was a problem hiding this comment.
we could add a special case for root paths, or try to implement a different gitignore root for each given search path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1919