feat: add --ignore-parent option to override --no-ignore-parent#1959
Open
tmchow wants to merge 1 commit intosharkdp:masterfrom
Open
feat: add --ignore-parent option to override --no-ignore-parent#1959tmchow wants to merge 1 commit intosharkdp:masterfrom
tmchow wants to merge 1 commit intosharkdp:masterfrom
Conversation
Add the --ignore-parent flag, mirroring the existing pattern where --ignore-vcs overrides --no-ignore-vcs. This lets users undo --no-ignore-parent in aliases or config files. Closes sharkdp#1958
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
--ignore-parentto undo--no-ignore-parent, filling a gap in the existing override pattern.Why this matters
Three flags already have an override counterpart:
--ignoreundoes--no-ignore,--ignore-vcsundoes--no-ignore-vcs, and--require-gitundoes--no-require-git. But--no-ignore-parenthad no way to be reversed once set in an alias or config. Users who set--no-ignore-parentglobally had no per-invocation escape hatch.Changes
src/cli.rs: Added--ignore-parentwithoverrides_with = "no_ignore_parent", matching the exact pattern used by--ignore-vcs(hidden flag,ArgAction::SetTrue, unit type). Updated theno_ignore_parentdoc comment to reference the new override.CHANGELOG.md: Added entry under## Featuresin the Unreleased section.No changes needed in
main.rssince clap'soverrides_withresetsno_ignore_parenttofalsewhen--ignore-parentappears later on the command line.Testing
cargo checkpassesignore_vcs(cli.rs:77-79)Fixes #1958
This contribution was developed with AI assistance (Claude Code).