Skip to content

fix: add aria-label to Newsletter input and nav links for FAQ/Testimonials #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shazzar00ni wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add aria-label to Newsletter input and nav links for FAQ/Testimonials #198

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
828d1a3
fix: add aria-label to Newsletter input and nav links for FAQ/Testimo…
shazzar00ni May 6, 2026
c5b5ba4
test: add aria-label unit tests for Input component
shazzar00ni May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/Newsletter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ export function Newsletter() {
<Input
type="email"
placeholder={NEWSLETTER_COPY.placeholder}
aria-label="Email"
Comment thread
shazzar00ni marked this conversation as resolved.
Outdated
value={email}
onChange={(e: React.ChangeEvent<HTMLInputElement>) => {
setEmail(e.target.value);
Expand Down
3 changes: 3 additions & 0 deletions src/components/ui/Input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ interface InputProps {
value?: string;
onChange?: (e: React.ChangeEvent<HTMLInputElement>) => void;
onBlur?: () => void;
'aria-label'?: string;
'aria-invalid'?: boolean;
Comment thread
shazzar00ni marked this conversation as resolved.
'aria-describedby'?: string;
}
Expand Down Expand Up @@ -43,6 +44,7 @@ export function Input({
value,
onChange,
onBlur,
'aria-label': ariaLabel,
...props
}: InputProps) {
return (
Expand All @@ -53,6 +55,7 @@ export function Input({
value={value}
onChange={onChange}
onBlur={onBlur}
aria-label={ariaLabel}
className={`w-full px-4 py-3 bg-slate-900 border border-slate-700 rounded-lg text-slate-100 placeholder:text-slate-500 focus:outline-none focus:ring-2 focus:ring-teal-500 focus:border-transparent transition-all duration-200 ${disabled ? 'opacity-50 cursor-not-allowed' : ''} ${className}`}
{...props}
/>
Expand Down
2 changes: 2 additions & 0 deletions src/data/content.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ export const NAV_LINKS = [
{ label: 'Features', href: '#features' },
{ label: 'How it Works', href: '#how-it-works' },
{ label: 'Pricing', href: '#pricing' },
{ label: 'FAQ', href: '#faq' },
{ label: 'Testimonials', href: '#testimonials' },
];

export const FOOTER_LINKS = [
Expand Down
Loading