docs(build): define canonical build contract across scripts and CI#222
docs(build): define canonical build contract across scripts and CI#222shazzar00ni wants to merge 1 commit into
Conversation
|
Strix is installed on this repository, but we could not run this PR security review because this workspace does not have an active plan. If you'd like to continue receiving code reviews, you can add a payment method or manage billing here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned Files
|
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Greptile SummaryThis PR establishes a canonical build contract for DocuGen:
Confidence Score: 4/5Safe to merge; both findings are minor CI efficiency and documentation observations with no functional regressions. The script and CI changes are correct and the cleanup of the duplicate permissions block and malformed Super-Linter step is a clear improvement. The
Important Files Changed
|
| Run this before every commit and in CI: | ||
|
|
||
| ```bash | ||
| npm run ci:verify | ||
| ``` | ||
|
|
||
| This command enforces the project contract in order: lint (`npm run lint`), unit tests (`npm run test:run`), and canonical build (`npm run build`). |
There was a problem hiding this comment.
ci:verify is not what actually runs in the CI pipeline
The README says to use npm run ci:verify "in CI", but the CI workflow (ci.yml) runs each stage as a separate parallel job — lint, test, typecheck, and build — not through ci:verify. A contributor reading this could reasonably believe the GitHub Actions workflow uses ci:verify as its entry point, when it does not. Consider rephrasing to "run locally before pushing" or "to replicate the CI checks locally" to avoid the ambiguity.



Motivation
Description
package.jsonscripts sonpm run buildrunsnpm run typecheck && vite build, addednpm run build:bundlefor bundle-only local diagnostics, and addednpm run ci:verifyto run lint + tests + canonical build..github/workflows/ci.yml) to run the same stages (npm run lint,npm run test:run,npm run typecheck, andnpm run build) and adjusted job ordering to reflect the contract.Build Contractsection todocs/DEVELOPMENT.mdand updatedREADME.md,docs/README.md, andAGENTS.mdto document the canonical commands and verification flow (npm run buildandnpm run ci:verify).npm run ci:verify).Testing
npm run ci:verifyand the command completed successfully.vitest runexecuted and reported all tests passing (13 files, 86 tests), indicating unit tests succeeded.tsc --noEmit(typecheck) completed without errors, indicating TypeScript validation passed.vite buildproduced a productiondist/output successfully (build completed), so the canonical build contract executed end-to-end.Codex Task