TextFieldWidget: clamp firstCharacterIndex when text is changed#1397
Open
eutro wants to merge 1 commit intoshedaniel:10.x-1.19.3from
Open
TextFieldWidget: clamp firstCharacterIndex when text is changed#1397eutro wants to merge 1 commit intoshedaniel:10.x-1.19.3from
firstCharacterIndex when text is changed#1397eutro wants to merge 1 commit intoshedaniel:10.x-1.19.3from
Conversation
Fixes a spurious crash in `render(..)` when it was out of bounds before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a spurious crash in
render(..)when it may have been out of bounds before.I had this crash happen twice on 1.18.2 in Stoneblock 3 (crash log). I don't have steps to reproduce, but I haven't had the issue since applying the fix (since, logically, the value can no longer be out of bounds). This may be a band-aid fix for a subtler bug, but at least it stops things from blowing up.