Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #212 +/- ##
==========================================
+ Coverage 40.18% 40.41% +0.23%
==========================================
Files 61 62 +1
Lines 5027 5050 +23
==========================================
+ Hits 2020 2041 +21
- Misses 3007 3009 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This looks really usefull! :) |
|
Thanks @RicardoMusch , for us internally it has been stable. Going to add documentations and then should be ready to merge |
| Display Hook and Settings | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| .. versionadded:: v2.x.x |
There was a problem hiding this comment.
I've left this as v2.x.x as I'm not sure how the merge and release process goes from Autodesk's side, but this should be changed prior to release
| for prop in ("action_name", "button_name", "menu_name", "menu_properties"): | ||
| assert hasattr(self.app.display_hook, prop) | ||
|
|
||
| def test_matches_v2_10_7(self): |
There was a problem hiding this comment.
Should I update all instances of v2_10_7 to v2_10_8 and make it match?
| HookBaseClass = sgtk.get_hook_baseclass() | ||
|
|
||
|
|
||
| class DisplayHook(HookBaseClass): |
There was a problem hiding this comment.
Should this default implementation be moved into base_hooks?
Add ability to customise the button text, menu and action names/properties using a hook instead.
Current implementation imitates existing behaviour without changes to any currently authored configs or settings
Added
displayconfig dict withhookand optionalsettingsMultiPublish2.display_hookget-only property to exposedisplay:hookinstanceChanged
MultiPublish2(app.py) intodisplay:hook.menu_nameanddisplay:hook.menu_propertiesand switched to call themAppDialog._display_action_namelogic intodisplay:hook.action_nameand switched to call itAppDialog.ui.publishto usedisplay:hook.button_namedisplay:hook.action_name