Modified setup.py and pyamgx/System.pyx.#37
Open
rwdlnk wants to merge 1 commit into
Open
Conversation
Changes needed to successfully install pyamgx on latest amgx install, Python3, and Ubuntu 22.04
shwina
reviewed
Jan 9, 2024
|
|
||
| from pyamgx_solver import PyAMGXSolver | ||
| with open (os.environ['AMGX_DIR']+'/core/configs/AMG_CLASSICAL_PMIS.json') as f: | ||
| #with open (os.environ['AMGX_DIR']+'/core/configs/AMG_CLASSICAL_PMIS.json') as f: |
shwina
reviewed
Jan 9, 2024
| library_dirs = [ | ||
| numpy.get_include(), | ||
| ] + AMGX_lib_dirs, | ||
| <<<<<<< HEAD |
Author
There was a problem hiding this comment.
Thanks for replying. Yes, I think I did a gitdiff and it messed up my files. Let me look these files over and get back to you. I'll rename the "tests" directory as you suggested.
Rod
shwina
reviewed
Jan 9, 2024
shwina
left a comment
shwina
left a comment
Owner
There was a problem hiding this comment.
Thanks for putting this together! For the examples, can we avoid the prefix test? I believe that will confuse pytest and it will attempt to run the module as if it contained unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes needed to successfully install pyamgx
on latest amgx install, Python3, and Ubuntu 22.04. Also corrected AMGX path for examples/FiPy/diffusion.py (changed core to src).