fix(application-header): launchpad Show more/less should have aria-expanded - #2400
Open
spike-rabbit wants to merge 1 commit into
Open
fix(application-header): launchpad Show more/less should have aria-expanded#2400spike-rabbit wants to merge 1 commit into
Show more/less should have aria-expanded#2400spike-rabbit wants to merge 1 commit into
Conversation
spike-rabbit
force-pushed
the
fix/launchpad-expanded-state
branch
from
July 23, 2026 10:12
c875bad to
862c788
Compare
spike-rabbit
changed the title
Show more/less should have aria-expanded
spike-rabbit
force-pushed
the
fix/launchpad-expanded-state
branch
from
July 23, 2026 10:33
862c788 to
0f9b1f2
Compare
spike-rabbit
marked this pull request as ready for review
July 23, 2026 10:48
spike-rabbit
force-pushed
the
fix/launchpad-expanded-state
branch
from
July 24, 2026 09:05
0f9b1f2 to
e218d34
Compare
…-expanded` Expose the Show more toggle state with aria-expanded so assistive technologies can determine whether the app list is expanded. DEPRECATED: `SiLaunchpadFactoryComponent.showLessAppsText` input is deprecated and no longer used. `SiLaunchpadFactoryComponent.showMoreAppsText` is always displayed, independent of the state.
spike-rabbit
force-pushed
the
fix/launchpad-expanded-state
branch
from
July 24, 2026 09:36
e218d34 to
bf1b536
Compare
| type="button" | ||
| class="btn btn-link btn-show-all dropdown-toggle text-decoration-none" | ||
| [class.show]="showAllApps" | ||
| [attr.aria-expanded]="showAllApps" |
Member
There was a problem hiding this comment.
wondering if there should also be aria-controls to indicate region
spliffone
requested changes
Jul 27, 2026
spliffone
left a comment
spliffone
left a comment
Member
There was a problem hiding this comment.
Can you add a schematic to remove the input?
Member
Author
|
I added this to the schematics issues. Will do in another PR. |
spliffone
enabled auto-merge
July 27, 2026 10:10
spike-rabbit
force-pushed
the
fix/launchpad-expanded-state
branch
from
July 30, 2026 13:43
d66834b to
bf1b536
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the Show more toggle state through
aria-expandedso assistive technologies can identify whether the launchpad app list is expanded.Always show
Show moreneverShow less.DEPRECATED:
SiLaunchpadFactoryComponent.showLessAppsTextinput is deprecated and no longer used.SiLaunchpadFactoryComponent.showMoreAppsTextis always displayed, independent of the state.Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: