-
Notifications
You must be signed in to change notification settings - Fork 21
docs: improve HTML table description and examples #2421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
spliffone
wants to merge
1
commit into
main
Choose a base branch
from
docs/update-html-table-documentation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 0 additions & 3 deletions
3
...pec.ts-snapshots/datatable--bootstrap-element-examples-chromium-light-linux.png
This file was deleted.
Oops, something went wrong.
3 changes: 3 additions & 0 deletions
3
...-snapshots/datatable--html-table-basic-element-examples-chromium-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
...snapshots/datatable--html-table-basic-element-examples-chromium-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
15 changes: 15 additions & 0 deletions
15
playwright/snapshots/static.spec.ts-snapshots/datatable--html-table-basic.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| - table: | ||
| - rowgroup: | ||
| - row "Device Status Last updated": | ||
| - columnheader "Device" | ||
| - columnheader "Status" | ||
| - columnheader "Last updated" | ||
| - rowgroup: | ||
| - row /Cooling unit Operational \d+:\d+/: | ||
| - rowheader "Cooling unit" | ||
| - cell "Operational" | ||
| - cell /\d+:\d+/ | ||
| - row /Ventilation unit Operational \d+:\d+/: | ||
| - rowheader "Ventilation unit" | ||
| - cell "Operational" | ||
| - cell /\d+:\d+/ |
3 changes: 3 additions & 0 deletions
3
...napshots/datatable--html-table-caption-element-examples-chromium-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
...apshots/datatable--html-table-caption-element-examples-chromium-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 10 additions & 0 deletions
10
playwright/snapshots/static.spec.ts-snapshots/datatable--html-table-caption.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| - table "Device status": | ||
| - caption: Device status | ||
| - rowgroup: | ||
| - row "Device Status": | ||
| - columnheader "Device" | ||
| - columnheader "Status" | ||
| - rowgroup: | ||
| - row "Cooling unit Operational": | ||
| - rowheader "Cooling unit" | ||
| - cell "Operational" |
File renamed without changes
3 changes: 3 additions & 0 deletions
3
...ec.ts-snapshots/datatable--html-table-element-examples-chromium-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
...shots/datatable--html-table-responsive-element-examples-chromium-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
...hots/datatable--html-table-responsive-element-examples-chromium-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions
21
playwright/snapshots/static.spec.ts-snapshots/datatable--html-table-responsive.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| - table: | ||
| - rowgroup: | ||
| - row "Device Status Last updated Location Operator": | ||
| - columnheader "Device" | ||
| - columnheader "Status" | ||
| - columnheader "Last updated" | ||
| - columnheader "Location" | ||
| - columnheader "Operator" | ||
| - rowgroup: | ||
| - row /Cooling unit Operational \d+:\d+ Building A Alex Smith/: | ||
| - rowheader "Cooling unit" | ||
| - cell "Operational" | ||
| - cell /\d+:\d+/ | ||
| - cell "Building A" | ||
| - cell "Alex Smith" | ||
| - row /Ventilation unit Operational \d+:\d+ Building B Jordan Lee/: | ||
| - rowheader "Ventilation unit" | ||
| - cell "Operational" | ||
| - cell /\d+:\d+/ | ||
| - cell "Building B" | ||
| - cell "Jordan Lee" |
3 changes: 3 additions & 0 deletions
3
...apshots/datatable--html-table-variants-element-examples-chromium-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
...pshots/datatable--html-table-variants-element-examples-chromium-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
19 changes: 19 additions & 0 deletions
19
playwright/snapshots/static.spec.ts-snapshots/datatable--html-table-variants.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| - table: | ||
| - rowgroup: | ||
| - row "Device Status Last updated": | ||
| - columnheader "Device" | ||
| - columnheader "Status" | ||
| - columnheader "Last updated" | ||
| - rowgroup: | ||
| - row /Cooling unit Operational \d+:\d+/: | ||
| - rowheader "Cooling unit" | ||
| - cell "Operational" | ||
| - cell /\d+:\d+/ | ||
| - row /Ventilation unit Selected \d+:\d+/: | ||
| - rowheader "Ventilation unit" | ||
| - cell "Selected" | ||
| - cell /\d+:\d+/ | ||
| - row /Heating unit Maintenance required \d+:\d+/: | ||
| - rowheader "Heating unit" | ||
| - cell "Maintenance required" | ||
| - cell /\d+:\d+/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <table class="table"> | ||
| <thead> | ||
| <tr> | ||
| <th scope="col">Device</th> | ||
| <th scope="col">Status</th> | ||
| <th scope="col">Last updated</th> | ||
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| <tr> | ||
| <th scope="row">Cooling unit</th> | ||
| <td>Operational</td> | ||
| <td>10:30</td> | ||
| </tr> | ||
| <tr> | ||
| <th scope="row">Ventilation unit</th> | ||
| <td>Operational</td> | ||
| <td>10:28</td> | ||
| </tr> | ||
| </tbody> | ||
| </table> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| /** | ||
| * Copyright (c) Siemens 2016 - 2026 | ||
| * SPDX-License-Identifier: MIT | ||
| */ | ||
| import { Component } from '@angular/core'; | ||
|
|
||
| @Component({ | ||
| selector: 'app-sample', | ||
| templateUrl: './html-table-basic.html', | ||
| host: { class: 'p-5' } | ||
| }) | ||
| export class SampleComponent {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| <table class="table caption-top"> | ||
| <caption>Device status</caption> | ||
| <thead> | ||
| <tr> | ||
| <th scope="col">Device</th> | ||
| <th scope="col">Status</th> | ||
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| <tr> | ||
| <th scope="row">Cooling unit</th> | ||
| <td>Operational</td> | ||
| </tr> | ||
| </tbody> | ||
| </table> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| /** | ||
| * Copyright (c) Siemens 2016 - 2026 | ||
| * SPDX-License-Identifier: MIT | ||
| */ | ||
| import { Component } from '@angular/core'; | ||
|
|
||
| @Component({ | ||
| selector: 'app-sample', | ||
| templateUrl: './html-table-caption.html', | ||
| host: { class: 'p-5' } | ||
| }) | ||
| export class SampleComponent {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| <div class="table-responsive" tabindex="0" aria-label="Scrollable device status table"> | ||
| <table class="table"> | ||
| <thead> | ||
| <tr> | ||
| <th scope="col">Device</th> | ||
| <th scope="col">Status</th> | ||
| <th scope="col">Last updated</th> | ||
| <th scope="col">Location</th> | ||
| <th scope="col">Operator</th> | ||
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| <tr> | ||
| <th scope="row">Cooling unit</th> | ||
| <td>Operational</td> | ||
| <td>10:30</td> | ||
| <td>Building A</td> | ||
| <td>Alex Smith</td> | ||
| </tr> | ||
| <tr> | ||
| <th scope="row">Ventilation unit</th> | ||
| <td>Operational</td> | ||
| <td>10:28</td> | ||
| <td>Building B</td> | ||
| <td>Jordan Lee</td> | ||
| </tr> | ||
| </tbody> | ||
| </table> | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| /** | ||
| * Copyright (c) Siemens 2016 - 2026 | ||
| * SPDX-License-Identifier: MIT | ||
| */ | ||
| import { Component } from '@angular/core'; | ||
|
|
||
| @Component({ | ||
| selector: 'app-sample', | ||
| templateUrl: './html-table-responsive.html', | ||
| host: { class: 'p-5' } | ||
| }) | ||
| export class SampleComponent {} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.