fix(datepicker): propagate date range validation to signal forms - #2426
Open
spike-rabbit wants to merge 1 commit into
Open
fix(datepicker): propagate date range validation to signal forms#2426spike-rabbit wants to merge 1 commit into
spike-rabbit wants to merge 1 commit into
Conversation
spike-rabbit
force-pushed
the
fix/date-range-signal-validation
branch
from
July 28, 2026 12:30
2e1d12e to
d03e2ca
Compare
spike-rabbit
marked this pull request as ready for review
July 28, 2026 12:32
Notify signal forms when nested date inputs change so format errors are re-evaluated. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
spike-rabbit
force-pushed
the
fix/date-range-signal-validation
branch
from
July 28, 2026 13:03
d03e2ca to
bf6e1d3
Compare
spliffone
reviewed
Jul 28, 2026
| this.updateValue(dateRange); | ||
|
|
||
| this.onChange(this.value()); | ||
| this.onValidatorChange(); |
Member
There was a problem hiding this comment.
Can you also call thie function in case the config changes e.g. on min / max date change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notify Signal Forms when nested date inputs change so date-range format errors are re-evaluated.
Testing
pnpm exec ng test element-ng --include='**/datepicker/si-date-range.component.spec.ts' --no-watchDocumentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: