fix(shadow-root): sync overlay styles - #2448
Open
chintankavathia wants to merge 1 commit into
Open
Conversation
chintankavathia
marked this pull request as ready for review
July 30, 2026 06:28
spike-rabbit
approved these changes
Jul 30, 2026
spike-rabbit
requested changes
Jul 30, 2026
spike-rabbit
left a comment
spike-rabbit
left a comment
Member
There was a problem hiding this comment.
was supposed to be Request Changes in the first place 😆
Keep the detached overlay shadow root synchronized with styles registered after its container is created. Fixes #2447
chintankavathia
force-pushed
the
fix/shadow-root-late-styles
branch
from
July 31, 2026 07:00
d1e9ab2 to
cd2345a
Compare
spike-rabbit
requested changes
Jul 31, 2026
|
|
||
| it('should copy styles registered after the overlay container was created', async () => { | ||
| fixture.componentInstance.open.set(true); | ||
| fixture.detectChanges(); |
Member
There was a problem hiding this comment.
Suggested change
| fixture.detectChanges(); | |
| await fixture.whenStable(); |
ideally there is no detectChanges
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the detached overlay shadow root synchronized with styles registered after its container is created.
Fixes #2447
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: