Refactor/variable spacers - #2471
Draft
dr-itz wants to merge 2 commits into
Draft
Conversation
Member
Author
dr-itz
force-pushed
the
refactor/variable-spacers
branch
4 times, most recently
from
July 31, 2026 14:38
fe5a40b to
ccd3b77
Compare
This introduces a single variable and fixes all compile errors caused by it. In a later step this can be refined. BREAKING CHANGE: The spacers in `$spacers` are now derived from CSS variables. This means they cannot be used in simple math expressions like before but require a `calc()` operation.
dr-itz
force-pushed
the
refactor/variable-spacers
branch
from
July 31, 2026 15:52
ccd3b77 to
06a62e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a playground for variable spacers, i.e. to try high-density layouts. Spacers are no longer fixed, but driven by CSS:
--element-spacer-inlinecontrols spacers in inline direction. Default is 16px, i.e. what we have now--element-spacer-blockcontrols spacers in block direction. Default is 16px, i.e. what we have nowTheme and all components are changed to work with CSS vars instead of hardcoded values. The demo
si-theme/spacer-controlsallows changing the values easily until next reload.Note: since spacers are defined in a single place, _spacers.scss it's possible to change to a CSS var per spacer and everything else. The important part here is the changes to the whole code-base so spacers are variable.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: