feat: limit Sigstore signer concurrency#510
feat: limit Sigstore signer concurrency#510hotcodemacha wants to merge 0 commit intosigstore:mainfrom
Conversation
|
@ashutoshcipher You can do |
|
I'd want to see if we can land this upstream if possible, there's an open PR already. |
|
@mihaimaruseac - Please help with review. Thanks |
|
I'd also suggest to wait for the upstream fix. |
ack |
|
Note/nit: It doesn't make sense to force push to have the PR look empty. The old commit is still available (921188b) |
|
@mihaimaruseac - I was trying to sync my folk main branch with main of model-transparency |
|
Oh, I see you were pushing from main branch. Makes sense. What I usually do is to actually still create a branch on my fork. This way, I can work in parallel on multiple things and synchronizing is simpler: [...]$ git switch main # assuming I was on any other branch, it's a no-op if already on main
[...]$ git push --rebase upstream main # assumes upstream is configured as the origin repo
[...]$ git switch - # switches to the other branch, or you can use the name, if you want a different one
[...]$ git rebase - # rebases on the previous branch (which was main)
[...]$ git push # automatically pushes to upstream, which should be configured to be the forkTo have this work I configure in my local clone to have |
Thats what I did as well for changed after that. I was just using git after a long while. So missed on best practices. |
Summary
Closes #469
Added a cross-process file lock to serialize Sigstore signing, preventing concurrent TUF metadata updates that can trigger FileExistsError during parallel operations
Declared filelock as a project dependency to support locking behavior in Sigstore signer operations
Added a unit test ensuring the Sigstore signer acquires and releases a global file lock, preventing concurrent access to the TUF metadata store during signing operations
Checklist