Skip to content

LT-22324: address Jason review comments

f606e05
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

LT-22324: add OpenType font feature options #870

LT-22324: address Jason review comments
f606e05
Select commit
Loading
Failed to load commit list.
GitHub Actions / NUnit Tests failed May 22, 2026 in 0s

2 fail, 74 skipped, 4 167 pass in 10m 44s

    1 files  ±0      1 suites  ±0   10m 44s ⏱️ - 1m 1s
4 243 tests +1  4 167 ✅  - 1  74 💤 ±0  2 ❌ +2 
4 252 runs  +1  4 176 ✅  - 1  74 💤 ±0  2 ❌ +2 

Results for commit f606e05. ± Comparison against earlier commit 1255c80.

Annotations

Check warning on line 0 in SIL.FieldWorks.Common.RootSites.RenderTimingSuiteTests

See this annotation in the file changed.

@github-actions github-actions / NUnit Tests

RunBenchmark("long-prose") (SIL.FieldWorks.Common.RootSites.RenderTimingSuiteTests) failed

test-results/Output/Debug/TestResults/runneradmin_runnervmqq1k9_2026-05-22_23_52_50.trx [took 2s]
Raw output
System.Runtime.InteropServices.COMException : 
---***More***---
Stack Dump:
Stack capture unavailable in this environment.
SymGetSymFromAddr(): gle = 126
   (no line # avail)


Stack Dump for exception: Access violation (-1073741819)

Version: 0, 0, 0, 0   at SIL.FieldWorks.Common.ViewsInterfaces._VwRootBoxClass.Layout(IVwGraphics _vg, Int32 dxsAvailWidth)
   at SIL.FieldWorks.Common.RootSites.RenderBenchmark.RenderBenchmarkHarness.PerformOffscreenLayout(Int32 width, Int32 height) in D:\a\FieldWorks\FieldWorks\Src\Common\RootSite\RootSiteTests\RenderBenchmarkHarness.cs:line 203
   at SIL.FieldWorks.Common.RootSites.RenderBenchmark.RenderBenchmarkHarness.<>c__DisplayClass25_0.<ExecuteColdRender>b__2() in D:\a\FieldWorks\FieldWorks\Src\Common\RootSite\RootSiteTests\RenderBenchmarkHarness.cs:line 104
   at SIL.FieldWorks.Common.RootSites.RenderBenchmark.RenderBenchmarkHarness.MeasureStage(String stage, Action action, Dictionary`2 context) in D:\a\FieldWorks\FieldWorks\Src\Common\RootSite\RootSiteTests\RenderBenchmarkHarness.cs:line 309
   at SIL.FieldWorks.Common.RootSites.RenderBenchmark.RenderBenchmarkHarness.ExecuteColdRender(Int32 width, Int32 height) in D:\a\FieldWorks\FieldWorks\Src\Common\RootSite\RootSiteTests\RenderBenchmarkHarness.cs:line 102
   at SIL.FieldWorks.Common.RootSites.RenderBenchmark.RenderBenchmarkTestsBase.ExecuteScenarioAndCapture(String scenarioId, Boolean includeWarmRender, RenderEnvironmentValidator environmentValidator, Int32 width, Int32 height) in D:\a\FieldWorks\FieldWorks\Src\Common\RootSite\RootSiteTests\RenderBenchmarkTestsBase.cs:line 356
   at SIL.FieldWorks.Common.RootSites.RenderTimingSuiteTests.RunBenchmark(String scenarioId) in D:\a\FieldWorks\FieldWorks\Src\Common\RootSite\RootSiteTests\RenderTimingSuiteTests.cs:line 59

Check warning on line 0 in SIL.FieldWorks.Common.Framework.DetailControls.DataTreeRenderTests

See this annotation in the file changed.

@github-actions github-actions / NUnit Tests

DataTreeRender_SubSubSubSenses_ShowHiddenFields_ProductionLike (SIL.FieldWorks.Common.Framework.DetailControls.DataTreeRenderTests) failed

test-results/Output/Debug/TestResults/runneradmin_runnervmqq1k9_2026-05-22_23_52_50.trx [took 9s]
Raw output
Render output for 'subsubsub-hidden-productionlike' differed from baseline by 34 pixels; 4 or fewer differences are allowed.
Saved baseline: image=1024x1296; lastWriteUtc=2026-05-22T23:47:14.5469968Z; captured=2026-04-07T19:31:52.0924150Z; envHash=3sUMmJxy5F2y; DPI=96x96; screen=1366x768; textScale=1; dpiAwareness=Unaware; fontSmoothing=true; clearType=true; theme=Light; culture=en-US; FW_FONT_QUALITY=4; font='Segoe UI' installed=true; machine=SIL-XPS; os=Microsoft Windows NT 10.0.26200.0
Current run: image=1024x1296; captured=2026-05-22T23:54:12.2687052Z; envHash=DzHAiejR3TJ8; DPI=96x96; screen=1024x768; textScale=1; dpiAwareness=Unaware; fontSmoothing=true; clearType=true; theme=Light; culture=en-US; FW_FONT_QUALITY=4; font='Segoe UI' installed=true; machine=runnervmqq1k9; os=Microsoft Windows NT 10.0.26100.0
Diff composition: inBounds=34; savedOnly=0; currentOnly=0; region=x=197..198, y=2..18, size=2x17.
Key differences: environmentHash saved=3sUMmJxy5F2y current=DzHAiejR3TJ8; screen saved=1366x768 current=1024x768
Artifacts: diff=D:\a\FieldWorks\FieldWorks\Src\Common\Controls\DetailControls\DetailControlsTests\DataTreeRenderTests.DataTreeRender_subsubsub-hidden-productionlike.diff.png; received=D:\a\FieldWorks\FieldWorks\Src\Common\Controls\DetailControls\DetailControlsTests\DataTreeRenderTests.DataTreeRender_subsubsub-hidden-productionlike.received.png; currentMetadata=D:\a\FieldWorks\FieldWorks\Src\Common\Controls\DetailControls\DetailControlsTests\DataTreeRenderTests.DataTreeRender_subsubsub-hidden-productionlike.received.json; comparison=D:\a\FieldWorks\FieldWorks\Src\Common\Controls\DetailControls\DetailControlsTests\DataTreeRenderTests.DataTreeRender_subsubsub-hidden-productionlike.diff.json.   at SIL.FieldWorks.Common.Framework.DetailControls.DataTreeRenderTests.<VerifyDataTreeBitmap>d__15.MoveNext() in D:\a\FieldWorks\FieldWorks\Src\Common\Controls\DetailControls\DetailControlsTests\DataTreeRenderTests.cs:line 419
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at SIL.FieldWorks.Common.Framework.DetailControls.DataTreeRenderTests.<DataTreeRender_SubSubSubSenses_ShowHiddenFields_ProductionLike>d__19.MoveNext() in D:\a\FieldWorks\FieldWorks\Src\Common\Controls\DetailControls\DetailControlsTests\DataTreeRenderTests.cs:line 604
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.GetResult()
   at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(Func`1 invoke)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__0()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

1)    at SIL.FieldWorks.Common.Framework.DetailControls.DataTreeRenderTests.<VerifyDataTreeBitmap>d__15.MoveNext() in D:\a\FieldWorks\FieldWorks\Src\Common\Controls\DetailControls\DetailControlsTests\DataTreeRenderTests.cs:line 419
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[TStateMachine](TStateMachine& stateMachine)
   at SIL.FieldWorks.Common.Framework.DetailControls.DataTreeRenderTests.VerifyDataTreeBitmap(Bitmap bitmap, String scenarioId)
   at SIL.FieldWorks.Common.Framework.DetailControls.DataTreeRenderTests.<DataTreeRender_SubSubSubSenses_ShowHiddenFields_ProductionLike>d__19.MoveNext() in D:\a\FieldWorks\FieldWorks\Src\Common\Controls\DetailControls\DetailControlsTests\DataTreeRenderTests.cs:line 604
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[TStateMachine](TStateMachine& stateMachine)
   at SIL.FieldWorks.Common.Framework.DetailControls.DataTreeRenderTests.DataTreeRender_SubSubSubSenses_ShowHiddenFields_ProductionLike()