Skip to content

Take detector orientation in account when converting from PONI to ImageD11#2868

Open
loichuder wants to merge 1 commit into
mainfrom
imaged11-orientation
Open

Take detector orientation in account when converting from PONI to ImageD11#2868
loichuder wants to merge 1 commit into
mainfrom
imaged11-orientation

Conversation

@loichuder

Copy link
Copy Markdown
Member

Fix #2090

Followed the mapping of

if (o11, o12, o21, o22) == (1, 0, 0, -1):

@loichuder loichuder requested a review from kif May 28, 2026 14:20

@kif kif left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Loic, thanks for addressing this "todo".
The code in itself looks great but the tricky thing is in the signs of the coefficients...

http://sylvana.net/jpegcrop/exif_orientation.html

  • Orientation3 is the default in pyFAI, the historical one. The fast scanning axis is flipped because we are looking from the sample and not from behind the camera.
  • Orientation 1&2 on the one hand and 3&4 on the other should only see a flip along the fast direction, which looks OK
  • Orientation 2 & 3 on the one hand and 1&4 should only differ in the vertical direction (or slow direction), so there should be only one sign change. This is likely wrong.

I will let James comment further on this @jadball.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manage orientation in the export to ImageD11

2 participants