Take detector orientation in account when converting from PONI to ImageD11#2868
Open
loichuder wants to merge 1 commit into
Open
Take detector orientation in account when converting from PONI to ImageD11#2868loichuder wants to merge 1 commit into
loichuder wants to merge 1 commit into
Conversation
kif
requested changes
May 29, 2026
kif
left a comment
Member
There was a problem hiding this comment.
Hi Loic, thanks for addressing this "todo".
The code in itself looks great but the tricky thing is in the signs of the coefficients...
http://sylvana.net/jpegcrop/exif_orientation.html
- Orientation3 is the default in pyFAI, the historical one. The fast scanning axis is flipped because we are looking from the sample and not from behind the camera.
- Orientation 1&2 on the one hand and 3&4 on the other should only see a flip along the fast direction, which looks OK
- Orientation 2 & 3 on the one hand and 1&4 should only differ in the vertical direction (or slow direction), so there should be only one sign change. This is likely wrong.
I will let James comment further on this @jadball.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2090
Followed the mapping of
pyFAI/src/pyFAI/geometry/imaged11.py
Line 174 in 74c73f9