Skip to content

Add blob/watershed method to Goniometer.extract_cp#2875

Open
EdgarGF93 wants to merge 6 commits into
silx-kit:mainfrom
EdgarGF93:2874_goniometer_blob_method
Open

Add blob/watershed method to Goniometer.extract_cp#2875
EdgarGF93 wants to merge 6 commits into
silx-kit:mainfrom
EdgarGF93:2874_goniometer_blob_method

Conversation

@EdgarGF93

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings June 6, 2026 11:41
@EdgarGF93 EdgarGF93 changed the title docs [Goniometer] Add blob/watershed method to Goniometer.extract_cp Jun 6, 2026
@EdgarGF93 EdgarGF93 changed the title [Goniometer] Add blob/watershed method to Goniometer.extract_cp Add blob/watershed method to Goniometer.extract_cp Jun 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the SingleGeometry.extract_cp API/docstring in pyFAI.goniometer around automatic control-point extraction.

Changes:

  • Adds a new method parameter to SingleGeometry.extract_cp.
  • Expands/adjusts the extract_cp docstring (documents method and Imin).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/pyFAI/goniometer.py Outdated
Comment thread src/pyFAI/goniometer.py Outdated
Comment thread src/pyFAI/goniometer.py
@EdgarGF93 EdgarGF93 self-assigned this Jun 6, 2026
@EdgarGF93 EdgarGF93 added the work in progress Don't review label Jun 6, 2026
@kif kif self-requested a review June 7, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

work in progress Don't review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants