Skip to content

ExternalResources: lock json file while accessing it#4597

Merged
kif merged 12 commits into
silx-kit:mainfrom
kif:4596_lock_json
May 28, 2026
Merged

ExternalResources: lock json file while accessing it#4597
kif merged 12 commits into
silx-kit:mainfrom
kif:4596_lock_json

Conversation

@kif

@kif kif commented May 12, 2026

Copy link
Copy Markdown
Member

PR summary

Lock ExternalResources to ensure several instances can use the same repository simultaneously without interfering.

AI Disclosure

  • No AI used
  • AI tool TabbyML used for generating docstrings

@kif kif requested a review from t20100 May 12, 2026 15:56
@kif

kif commented May 12, 2026

Copy link
Copy Markdown
Member Author

close #4596
Validation tested in silx-kit/pyFAI#2853

@t20100 t20100 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some unrelated change in fitmanager.py, can you remove them before merging?
Otherwise, looks ok to me

@kif

kif commented May 28, 2026

Copy link
Copy Markdown
Member Author

There is some unrelated change in fitmanager.py, can you remove them before merging? Otherwise, looks ok to me

The beauty of black

@kif kif merged commit 3a4c78b into silx-kit:main May 28, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants