-
Notifications
You must be signed in to change notification settings - Fork 82
Utils: add an helper to increase opened file soft limit #4613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,49 @@ | ||||||||||||||||||||||||
| # /*########################################################################## | ||||||||||||||||||||||||
| # | ||||||||||||||||||||||||
| # Copyright (c) 2019 European Synchrotron Radiation Facility | ||||||||||||||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If set best to use the right date:
Suggested change
|
||||||||||||||||||||||||
| # | ||||||||||||||||||||||||
| # Permission is hereby granted, free of charge, to any person obtaining a copy | ||||||||||||||||||||||||
| # of this software and associated documentation files (the "Software"), to deal | ||||||||||||||||||||||||
| # in the Software without restriction, including without limitation the rights | ||||||||||||||||||||||||
| # to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||||||||||||||||||||||||
| # copies of the Software, and to permit persons to whom the Software is | ||||||||||||||||||||||||
| # furnished to do so, subject to the following conditions: | ||||||||||||||||||||||||
| # | ||||||||||||||||||||||||
| # The above copyright notice and this permission notice shall be included in | ||||||||||||||||||||||||
| # all copies or substantial portions of the Software. | ||||||||||||||||||||||||
| # | ||||||||||||||||||||||||
| # THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||||||||||||||||||||||||
| # IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||||||||||||||||||||||||
| # FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||||||||||||||||||||||||
| # AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||||||||||||||||||||||||
| # LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||||||||||||||||||||||||
| # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||||||||||||||||||||||||
| # THE SOFTWARE. | ||||||||||||||||||||||||
| # | ||||||||||||||||||||||||
| # ###########################################################################*/ | ||||||||||||||||||||||||
| """Utils function relative to system limit""" | ||||||||||||||||||||||||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. well, i miss of imagination here |
||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| __authors__ = ["M. Ruyer"] | ||||||||||||||||||||||||
| __license__ = "MIT" | ||||||||||||||||||||||||
| __date__ = "05/06/2026" | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| import logging | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| _logger = logging.getLogger() | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| def increase_max_opened_files(): | ||||||||||||||||||||||||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what do you think about that name ?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||||||||||||||||||||||||
| """Use max opened files hard limit as soft limit""" | ||||||||||||||||||||||||
| try: | ||||||||||||||||||||||||
| import resource | ||||||||||||||||||||||||
| except ImportError: | ||||||||||||||||||||||||
| _logger.debug("No resource module available") | ||||||||||||||||||||||||
| else: | ||||||||||||||||||||||||
| if hasattr(resource, "RLIMIT_NOFILE"): | ||||||||||||||||||||||||
|
Comment on lines
+37
to
+42
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What about putting import at the top of the file to avoid lazy loading: and use this here:
Suggested change
|
||||||||||||||||||||||||
| try: | ||||||||||||||||||||||||
| hard_nofile = resource.getrlimit(resource.RLIMIT_NOFILE)[1] | ||||||||||||||||||||||||
| resource.setrlimit(resource.RLIMIT_NOFILE, (hard_nofile, hard_nofile)) | ||||||||||||||||||||||||
| except (ValueError, OSError): | ||||||||||||||||||||||||
| _logger.warning("Failed to retrieve and set the max opened files limit") | ||||||||||||||||||||||||
| else: | ||||||||||||||||||||||||
| _logger.debug("Set max opened files to %d", hard_nofile) | ||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no reason to change import order in this PR