Skip to content

Address PR 44074 sleep backend review comments#6

Draft
simon-mo wants to merge 2 commits into
cursor/pr44074-base-e42cfrom
cursor/review-pr-44074-e42c
Draft

Address PR 44074 sleep backend review comments#6
simon-mo wants to merge 2 commits into
cursor/pr44074-base-e42cfrom
cursor/review-pr-44074-e42c

Conversation

@simon-mo

@simon-mo simon-mo commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Purpose

Address review comments on vllm-project#44074 without opening another upstream PR against main:

  • Move the new sleep-mode backend tests out of the top-level tests/ directory into tests/v1/worker/test_gpu_worker.py.
  • Remove speculative/NCCL-specific capability methods from the generic SleepModeBackend abstraction, keeping only suspend/resume/state and platform support validation.

Duplicate-work check: vllm-project#44074 is the existing upstream PR for the sleep-mode backend abstraction; this helper PR is intentionally based on a local copy of that PR's pre-fix head so the diff contains only comment fixes. Also checked open upstream PRs for 44074 in:body and sleep mode backend abstraction; vllm-project#45398 depends on vllm-project#44074 rather than duplicating this helper change.

AI assistance was used to prepare these changes.

Test Plan

  • .venv/bin/python -m pytest tests/v1/worker/test_gpu_worker.py -q
  • .venv/bin/pre-commit run ruff-check --files vllm/device_allocator/sleep_mode_backend.py tests/v1/worker/test_gpu_worker.py

Test Result

  • 11 passed, 16 warnings in 8.58s
  • ruff check ... Passed

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
Open in Web Open in Cursor 

simon-mo and others added 2 commits June 30, 2026 18:05
Co-authored-by: GPT-5.5 <gpt-5.5@cursor.ai>
Co-authored-by: GPT-5.5 <gpt-5.5@cursor.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant