Address PR 44074 sleep backend review comments#6
Draft
simon-mo wants to merge 2 commits into
Draft
Conversation
Co-authored-by: GPT-5.5 <gpt-5.5@cursor.ai>
Co-authored-by: GPT-5.5 <gpt-5.5@cursor.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Address review comments on vllm-project#44074 without opening another upstream PR against
main:tests/directory intotests/v1/worker/test_gpu_worker.py.SleepModeBackendabstraction, keeping only suspend/resume/state and platform support validation.Duplicate-work check: vllm-project#44074 is the existing upstream PR for the sleep-mode backend abstraction; this helper PR is intentionally based on a local copy of that PR's pre-fix head so the diff contains only comment fixes. Also checked open upstream PRs for
44074 in:bodyandsleep mode backend abstraction; vllm-project#45398 depends on vllm-project#44074 rather than duplicating this helper change.AI assistance was used to prepare these changes.
Test Plan
.venv/bin/python -m pytest tests/v1/worker/test_gpu_worker.py -q.venv/bin/pre-commit run ruff-check --files vllm/device_allocator/sleep_mode_backend.py tests/v1/worker/test_gpu_worker.pyTest Result
11 passed, 16 warnings in 8.58sruff check ... PassedEssential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.