Add test-writing guidance to AGENTS.md#7
Draft
simon-mo wants to merge 11 commits into
Draft
Conversation
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com> Co-authored-by: sherryC41 <sherry.c.c41@gmail.com> Co-authored-by: Matthew Bonanni <mbonanni@redhat.com>
…P8 KV (vllm-project#47276) Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com> Co-authored-by: nnyrhila <niko.nyrhila@amd.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
cursor
Bot
force-pushed
the
cursor/agents-test-guidance-9d34
branch
from
49951c4 to
4df2454
Compare
…tion + Mistral/Granite parsers) (vllm-project#47550) Signed-off-by: Aakif Nawaz <aakif.nawaz@amd.com> Signed-off-by: Andreas Karatzas <akaratza@amd.com> Co-authored-by: Andreas Karatzas <akaratza@amd.com>
Document principles for adding tests: reuse existing harnesses and suites, focus on meaningful behavior over trivial coverage, and borrow patterns from Linux, Kubernetes, and PyTorch testing practices. Co-authored-by: Cursor Agent
Replace project-specific citations with distilled principles for reusing existing harnesses, writing meaningful behavior tests, and keeping tests reliable and independent. Co-authored-by: Cursor Agent
- Merge Running tests and Adding tests into a leaner Tests section - Offset added content by trimming coding style and commit examples - Add guidance against one-off kernel benchmarks in tests/ - Require model eval results in PRs for output/accuracy changes Co-authored-by: Cursor Agent
cursor
Bot
force-pushed
the
cursor/agents-test-guidance-9d34
branch
from
4df2454 to
6a32233
Compare
Co-authored-by: Cursor Agent
- State test reason in name or docstring (AndreasKaratzas) - Add keep-it-minimal principle; skip other suggestions to stay lean per simon-mo Co-authored-by: Cursor Agent
Merge behavior/reason bullets to offset length while keeping Design before you write and Keep it minimal as the two top picks. Co-authored-by: Cursor Agent
Co-authored-by: Benjamin Chislett <chislett.ben@gmail.com> Signed-off-by: Simon Mo <simon.mo@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new Adding tests section to
AGENTS.mdwith project-wide guidance for writing meaningful tests.What changed
conftest.pyfixtures, and shared helpers over creating new test files or bespoke harnesses.docs/contributing/model/tests.md.Why this is not duplicating an existing PR
No open PR adds general test-writing guidance to
AGENTS.md.Test commands run
Documentation-only change; no code tests required.
AI assistance
AI assistance was used to draft this documentation update.