Fix after_call not firing when model calls a non-existent tool - #1526
Open
ikatyal2110 wants to merge 1 commit into
Open
Fix after_call not firing when model calls a non-existent tool#1526ikatyal2110 wants to merge 1 commit into
ikatyal2110 wants to merge 1 commit into
Conversation
When a tool call references a tool name that does not exist, the sync and async executors built an error ToolResult and continued to the next call without invoking the after_call hook. This meant --td (tools-debug) showed no output for failed/unknown tool calls, as reported in issue simonw#1151.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a model calls a tool by a name that does not appear in the configured tool list, the sync and async executors returned an error ToolResult but skipped the after_call hook entirely, so --td produced no debug output for those failed calls. Both paths now invoke after_call with tool=None before continuing, matching the existing behaviour of before_call for unknown tools. Fixes #1151