Fix schema_dsl() IndexError when a field has no name before the colon - #1546
Open
ikatyal2110 wants to merge 1 commit into
Open
Fix schema_dsl() IndexError when a field has no name before the colon#1546ikatyal2110 wants to merge 1 commit into
ikatyal2110 wants to merge 1 commit into
Conversation
When field_info is empty (e.g. ':some description'), field_info.strip().split() returns [] and field_parts[0] raises IndexError. Skip the field with continue when field_parts is empty, consistent with how blank field strings are already filtered out during parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
schema_dsl()receives a field with no name before the colon (e.g.':description'or'name, :description'),field_info.strip().split()returns an empty list and the subsequentfield_parts[0]indexing raisesIndexError. The fix adds acontinueguard whenfield_partsis empty, silently skipping nameless fields; two new parametrize cases intest_utils.pycover both the all-nameless and mixed cases. Fixes #1545