Fix crash when the same file is passed as --attachment twice - #1550
Open
ikatyal2110 wants to merge 1 commit into
Open
Fix crash when the same file is passed as --attachment twice#1550ikatyal2110 wants to merge 1 commit into
ikatyal2110 wants to merge 1 commit into
Conversation
… twice When `--attachment` is given the same path more than once, all occurrences hash to the same attachment_id. The second INSERT into prompt_attachments (pk: response_id, attachment_id) raised `sqlite3.IntegrityError: UNIQUE constraint failed`, crashing after the model had already responded. Fixes simonw#1354
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the same file path is given to
--attachmentmore than once, every occurrence produces the sameattachment_id(SHA-256 of file bytes). The secondINSERTintoprompt_attachments— whose primary key is(response_id, attachment_id)— then fails withsqlite3.IntegrityError: UNIQUE constraint failed, crashing after the model has already replied. Addingignore=Trueto that insert silently drops the duplicate row and lets logging complete normally. Fixes #1354Generated by Claude Code