Fall back to suffix match when model calls tool without toolbox prefix - #1552
Open
ikatyal2110 wants to merge 1 commit into
Open
Fall back to suffix match when model calls tool without toolbox prefix#1552ikatyal2110 wants to merge 1 commit into
ikatyal2110 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some models (notably Qwen via Ollama) strip the toolbox class-name prefix when invoking a tool, calling "execute_javascript" instead of the registered "QuickJS_execute_javascript". This caused a "tool does not exist" error even though the tool was available.
When an exact name lookup fails, the fix tries to find a unique tool whose registered name ends with "_<called_name>". If exactly one such tool is found it is used; when multiple toolboxes share the same function name the call still fails with the original error so there is no ambiguity. The same fallback is applied in both the sync and async execution paths. Fixes #1105
Generated by Claude Code