Fix embed and similar commands using platform default encoding instead of UTF-8 for file input - #1559
Open
ikatyal2110 wants to merge 1 commit into
Open
Fix embed and similar commands using platform default encoding instead of UTF-8 for file input#1559ikatyal2110 wants to merge 1 commit into
ikatyal2110 wants to merge 1 commit into
Conversation
…coding instead of UTF-8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
llm embed -i fileorllm similar -i fileread text files, they calledopen(path, "r")without an explicit encoding, letting Python fall back to the platform default (which can belatin-1orasciion some systems). On those systems, UTF-8 files containing characters likeæorøwere silently misread, and the corrupted text was stored inembeddings.db. The stdin path had the same problem, reading fromsys.stdininstead of decodingsys.stdin.bufferas UTF-8. Both paths now explicitly use UTF-8 for text mode, matching theembed-multi --filespath which already tried UTF-8 first. Fixes #283Generated by Claude Code