Narrow except ValueError in embed-multi to only handle missing-model case - #1578
Open
ikatyal2110 wants to merge 2 commits into
Open
Narrow except ValueError in embed-multi to only handle missing-model case#1578ikatyal2110 wants to merge 2 commits into
ikatyal2110 wants to merge 2 commits into
Conversation
…rrors A broad `except ValueError` around `Collection()` would mask any ValueError from database migrations or other internal operations with the misleading "no embedding model" message. Only catch ValueError when no model was specified.
Sanjays2402
reviewed
Aug 1, 2026
| "You need to specify an embedding model (no default model is set)" | ||
| ) | ||
| collection_obj = Collection(collection, db=db, model_id=effective_model_id) | ||
| except ValueError as e: |
There was a problem hiding this comment.
the same masking exists in embed a couple hundred lines up: if -m names a model that isn't installed, get_embedding_model raises UnknownModelError and the handler turns it into "You need to specify an embedding model (no default model is set)", which is confusing when you did specify one. worth the same if model is None guard there so an unknown-model error surfaces as itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The broad
except ValueErroraroundCollection()in theembed-multicommand would silently convert any ValueError (e.g. from a database migration failure) into the misleading "You need to specify an embedding model" message. The fix extracts the model ID first, then only shows the user-friendly message when no model was provided; all other ValueErrors are re-raised. A regression test verifies that a non-model ValueError propagates instead of being masked. Fixes #1523Generated by Claude Code