Skip to content

Upgrade Svelte to v5. Replace Jest with Vitest. Upgrade other packages #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
internettrans merged 7 commits into from
Jul 23, 2025
Merged

Upgrade Svelte to v5. Replace Jest with Vitest. Upgrade other packages #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7f82db2
Upgrade svelte to v5. Replace jest with vitest. Upgrade other packages
mac89 Jul 7, 2025
25d0c97
Revert removal of .babelrc.
mac89 Jul 14, 2025
b88a865
Correct pre-commit command
mac89 Jul 14, 2025
34bfbb1
Move setupTests.js to src dir
mac89 Jul 17, 2025
bcd732b
Revert babel removal
mac89 Jul 17, 2025
f38d483
Update node and pnpm versions
mac89 Jul 17, 2025
1ee6399
Remove svelte as dependency. Add mount and unmount as required options
mac89 Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .eslintrc
View file
Open in desktop

This file was deleted.

8 changes: 3 additions & 5 deletions .github/workflows/build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@ jobs:

steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/setup-node@v4
with:
node-version: "16"
- uses: pnpm/action-setup@v2.0.1
with:
version: 6.2.5
node-version: "20"
- uses: pnpm/action-setup@v4.1.0
- run: pnpm install --frozen-lockfile
- run: pnpm test
- run: pnpm run lint
Expand Down
2 changes: 1 addition & 1 deletion .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

pnpx pretty-quick --staged && pnpx lint
pnpm exec pretty-quick --staged && pnpm run lint
13 changes: 13 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import { defineConfig } from "eslint/config";
import babelParser from "@babel/eslint-parser";

export default defineConfig([
{
languageOptions: {
parserOptions: {
parser: babelParser,
ecmaVersion: "latest",
},
},
},
]);
30 changes: 14 additions & 16 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@
"version": "2.1.1",
"description": "a single-spa plugin for svelte applications",
"main": "lib/single-spa-svelte.js",
"packageManager": "pnpm@10.13.1+sha224.c405af218a5ae22c848f557c21c3821030ab4e2386260bcf01dc2ea0",
"scripts": {
"build": "rimraf lib && babel src/single-spa-svelte.js --out-file lib/single-spa-svelte.js --source-maps",

@internettrans internettrans Jul 12, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babel is still being used here - why was the .babelrc removed?

@mac89 mac89 Jul 14, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, reverting

@internettrans internettrans Jul 17, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

babel is still missing from devDependencies after the latest commits. I'd like to also change the package.json to use exports rather than main, with type: "module", but can do that in a follow-up pull request if you do not have the time to do so in this one. The module format of the code in the lib folder should be ESM

@mac89 mac89 Jul 18, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have time to do so at the moment, so have to add it a later point.

"test": "cross-env BABEL_ENV=test jest",
"test": "vitest",
"lint": "eslint src",
"format": "prettier --write .",
"check-format": "prettier --check .",
Expand All @@ -32,20 +33,17 @@
},
"homepage": "https://github.com/single-spa/single-spa-svelte#readme",
"devDependencies": {
"@babel/cli": "^7.13.16",
"@babel/core": "^7.14.2",
"@babel/eslint-parser": "^7.14.2",
"@babel/preset-env": "^7.14.2",
"@types/jest": "^26.0.23",
"babel-jest": "^26.6.3",
"cross-env": "^7.0.3",
"eslint": "^7.26.0",
"eslint-config-important-stuff": "^1.1.0",
"husky": "^6.0.0",
"jest": "^26.6.3",
"jest-cli": "^26.6.3",
"prettier": "^2.3.0",
"pretty-quick": "^3.1.0",
"rimraf": "^3.0.2"
"@babel/cli": "^7.28.0",
"@babel/core": "^7.28.0",
"@babel/eslint-parser": "^7.28.0",
"@babel/preset-env": "^7.28.0",
"@sveltejs/vite-plugin-svelte": "^5.1.0",
"eslint": "^9.30.1",
"husky": "^9.1.7",
"prettier": "^3.6.2",
"pretty-quick": "^4.2.2",
"rimraf": "^6.0.1",
"vite": "^6.3.5",
"vitest": "^3.2.4"
}
}
Loading
Loading