Fix/dj pipe and improvements#39
Open
MaxFBurg wants to merge 7 commits intosinzlab:masterfrom
Open
Conversation
Member
Author
|
Now includes #14 |
| torch | ||
| scipy>=1.7.0,<=1.12.0 | ||
| numpy>=1.22.0,<=1.26.4 | ||
| numpy>=1.21.0,<=1.26.4 |
Collaborator
There was a problem hiding this comment.
Why was it previously less loose, do we know?
Member
Author
There was a problem hiding this comment.
I am not aware that we would know. @PPierzc do you have a hunch?
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @PPierzc @Mvystrcilova , I just checked the datajoint demo notebook, and there were some bugs in the DJ pipeline that prevented executing it. I fixed those bugs, improved a naming convention for
MEIMixinand added**kwargsthat forward todj.insertand to.load_model(the latter is required for the same functionality that was introduced for the model cache here #17 ). I am not sure about theCSRFV1Selectortable: this table is required, but was not implemented. I implemented it similar as how it was done innndichromacyand tested that it works with the mouse sensorium 2022 images data.This PR also includes the already approved and not yet merged PR #37