Fix PurePath.as_uri() deprecation warning in Python 3.14+#470
Closed
miettal wants to merge 1 commit intosissaschool:masterfrom
Closed
Fix PurePath.as_uri() deprecation warning in Python 3.14+#470miettal wants to merge 1 commit intosissaschool:masterfrom
miettal wants to merge 1 commit intosissaschool:masterfrom
Conversation
Suppress the DeprecationWarning for PurePath.as_uri() in LocationPath.as_uri() method. The warning appears in Python 3.14+ as PurePath.as_uri() is scheduled for removal in Python 3.19. The LocationPath class provides a custom implementation that doesn't call the parent method and is necessary for proper URI conversion of location paths. The deprecation warning is safely suppressed as this is an intentional override with a valid use case. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
|
The current implementation shouldn't use the PurePath.as_uri(), maybe it happens with the usage of another API. Do you have an evidence of that with a specific case that generates the warning? (better open an issue in this case) thank you |
Author
|
Sorry I only have pytest ignore setting now. This is a pattern of the warning. |
Member
|
Well, but with latest versions of xmlschema and elementpath the tests run doesn't produce any warning to me, also with pytest. Can you report which test/tests produce a warning? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Suppress DeprecationWarning for
PurePath.as_uri()in Python 3.14+.Problem
Python 3.14 deprecated
PurePath.as_uri()(removal scheduled for 3.19). This causes warnings whenLocationPath.as_uri()is called.Solution
Add
warnings.catch_warnings()to suppress the deprecation warning inLocationPath.as_uri(). The custom implementation doesn't call the parent method and provides necessary functionality for URI conversion.Changes
warningsmodule🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com