Skip to content

grouping examples into sections#2102

Open
maureen-githaiga wants to merge 6 commits into
skrub-data:mainfrom
maureen-githaiga:moving_examples
Open

grouping examples into sections#2102
maureen-githaiga wants to merge 6 commits into
skrub-data:mainfrom
maureen-githaiga:moving_examples

Conversation

@maureen-githaiga

@maureen-githaiga maureen-githaiga commented May 28, 2026

Copy link
Copy Markdown

fixes #690

Grouped examples into different sections/folders.

@rcap107 rcap107 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @maureen-githaiga, this will be useful.

There are a few things that need to be fixed

At the moment, the examples that have been moved to the new folders are not being rendered because the folders are missing a file that's called GALLERY_HEADER.rst and that contains the title of the section. You can check out those that are already in the folder as examples of what they look like.

Some of the examples should be moved in locations different from where they currently are.

Also, the name of the folders themselves should be prefixed by a number (like "01_encoding", 02_data_ops", "03_joiners". Doing so allows us to set the order of the folders.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be moved back to the fixme folder (we might be removing this entirely)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For both this and the other joiners, there is no need to nest it twice: having the "joiners" section on its own is enough, so this should be moved up by one folder.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, move up

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, move up

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, move up

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, move up

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can go in the root examples/ folder

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may also go in the root examples folder

Comment thread CHANGES.rst Outdated

Changes
-------
- Grouped Examples into three sections. :pr:`690` by

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PR number is 2102 (690 is the relevant issue)

Suggested change
- Grouped Examples into three sections. :pr:`690` by
- Grouped Examples into three sections. :pr:`2102` by

@rcap107 rcap107 added this to the Release 0.10 milestone Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Divide examples in sections

3 participants