Skip to content

patch_display now uses the minimal TableReport #2103

Draft
ashiorkornortey wants to merge 1 commit into
skrub-data:mainfrom
ashiorkornortey:maint-patch-display-minimal-report
Draft

patch_display now uses the minimal TableReport #2103
ashiorkornortey wants to merge 1 commit into
skrub-data:mainfrom
ashiorkornortey:maint-patch-display-minimal-report

Conversation

@ashiorkornortey

@ashiorkornortey ashiorkornortey commented May 28, 2026

Copy link
Copy Markdown

Bug Fix Pull Request

Description

Addresses #1972

Checklist

  • I have read the contributing guidelines
  • I have added tests that verify the bug fix
  • I have added an entry to CHANGES.rst describing the fix
  • My code follows the code style of this project
  • I have checked my code and corrected any misspellings

How Has This Been Tested?

AI Disclosure

  • This PR contains AI-generated code
    • I have tested the code generated in my PR
    • I have read and understood every line that has been generated by the AI agent
    • I can explain what the AI-generated code does

@jeromedockes jeromedockes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much @ashiorkornortey !! very useful

@@ -0,0 +1,30 @@
<table border="1" class="dataframe">

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this file and products.html were added due to a git mishap maybe, could you remove this generated_for_index folder and its content? (note this is the added generated_for_index at the top of the directory; the existing doc/generated_for_index does not need to change

)(),
)

def _patched(df, *args, **kwargs):

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you add the *args and **kwargs here?

@rcap107 rcap107 changed the title first commit patch_display now uses the minimal TableReport May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Pyladies Tampere sprint May 2026 TableReport anything related to the TableReport

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MAINT - change the patch_display function so that it uses the minimal TableReport

2 participants