Get memory limit by walking up the cgroup tree.#1872
Open
mgoulish wants to merge 2 commits into
Open
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| FILE *f; | ||
|
|
||
| // cgroup v2 | ||
| snprintf(path, sizeof(path), "%s/memory.max", dir); |
| FILE *f; | ||
|
|
||
| // cgroup v2 | ||
| snprintf(path, sizeof(path), "%s/memory.max", dir); |
ted-ross
requested changes
Jun 10, 2026
ted-ross
left a comment
ted-ross
left a comment
Member
There was a problem hiding this comment.
Please raise an issue for this bug. Also, please remove the changes to tcp_adaptor.c and server.c, which are just added empty lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change gets the router memory limit by starting at the cgroup node that represents the router process, and then walking up the tree, parent to parent, to find the most restrictive memory limit.
When I ran the router this way:
It correctly produced this log output:
And then it correctly ran my test of 20,000 TCP connections across a 2-router network, and both routers stayed below (just barely below) 1.0 GB.