EventDeduplicator must close its own channel

[nluaces]

Fixes #2485

[c-kruse]

I think that this introduces a different chance for a panic: QueueEvent after Stop tries to send on a closed eventCh channel.

Rather than trying to guard QueueEvent or something, I think we'd be better off with a new done channel owned by the EventDeduplicator to clean up goroutine(s) when Stop() is called instead of giving eventCh a second purpose.

As an aside, I'm not sure there's much reason to split out a new goroutine to listen for stopCh. It may end up cleaner to keep everything in processEvents.

[nluaces]

@c-kruse I see your point. Regarding what you have said here

As an aside, I'm not sure there's much reason to split out a new goroutine to listen for stopCh. It may end up cleaner to keep everything in processEvents.

The reason of the splitting was that during testing, after queuing a new event and stopping the channel, proccesEvents was choosing randomly to process the event rather than stopping its channel most of the time.

I will try what you have suggested.

[c-kruse]

Thank you!