Refactored controller_test.go to use helper functions#2496
Open
evanwang9x wants to merge 1 commit into
Open
Conversation
c-kruse
reviewed
Jun 12, 2026
| Edge: edge, | ||
| }, | ||
| } | ||
| s := utils.NewSite(name, namespace) |
Contributor
There was a problem hiding this comment.
Let's put these in their own fixture package instead of dumping them in utils. fixture.Site() reads cleaner than utils.NewSite() IMO. That, and it is poor style to mix the code for test helpers in with code compiled into our released executables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan is to later use these helper functions in the other test suites
Closes #2495