Support QMainWindow .ui files in load_ui_file#1326
Open
YektaY wants to merge 5 commits intoslaclab:masterfrom
Open
Support QMainWindow .ui files in load_ui_file#1326YektaY wants to merge 5 commits intoslaclab:masterfrom
YektaY wants to merge 5 commits intoslaclab:masterfrom
Conversation
|
I've tested this and it works |
Enable CI workflows on fork
Detect root widget class from .ui XML and use MainWindowDisplay (QMainWindow-based) when the file defines a QMainWindow, avoiding the AttributeError on setCentralWidget. Fixes slaclab#1321
YektaY
force-pushed
the
YektaY/fix_mainwindow_designer#1321
branch
from
81142e8 to
0ed221e
Compare
Extract shared display logic into DisplayBase mixin so both Display (QWidget) and MainWindowDisplay (QMainWindow) share the full interface. Update isinstance checks to use DisplayBase so navigation, menus, and macro propagation work for both types. Fixes slaclab#1321
|
If you try and reload a main window display from the menu, the window doesn't reload raceback (most recent call last): This works now, decreasing or increasing font size resets the window size but that's fine |
Collaborator
|
I think this looks like a reasonable way of doing it since it leaves existing displays alone. Should be good once the reload is cleaned up. |
|
tested again, reload works now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect root widget class from .ui XML and use MainWindowDisplay (QMainWindow-based) when the file defines a QMainWindow, avoiding the AttributeError on setCentralWidget.
Note: not sure this is the best approach or even a good idea to support QMainWindow as a root widget
Fixes #1321