Duplicates#227
Open
michaellans wants to merge 7 commits intoslaclab:mainfrom
Open
Conversation
zdomke
requested changes
Mar 16, 2026
Collaborator
zdomke
left a comment
zdomke
left a comment
There was a problem hiding this comment.
This PR looks good, but we (@YektaY, @ngAlexander9, and @zdomke) are concerned that preventing adding duplicates is done silently or without the user knowing.
We propose that a new checkbox be added to the Search PVs Window that can enable/disable this behavior. That way if a user intends to add duplicates then they are still able to.
The checkbox should probably be near the "Add PVs" button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Check for and handle adding duplicate PVs. If adding a list of PVs, any PV already on the plot will be skipped. Adding an individual PV from the lineEdit which is already on the plot will result in a duplicate curve for that PV plotted on a new axis.
Motivation
Users noticed unexpected behavior with duplicate PVs when adding from list:
[BUG] - if add PV from search window and the PV already exists, it's added again #220
Where Has This Been Documented?
Added docstring and comments to ControlPanel.add_curve explaining "duplicate" option