ENH: Add indication that archive data is being fetched to the plot#238
Merged
Conversation
…en it takes longer than a couple seconds to retrieve
zdomke
approved these changes
Mar 16, 2026
Collaborator
zdomke
left a comment
zdomke
left a comment
There was a problem hiding this comment.
Looks great to me! Also checked darkmode and it looks good in that too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements #223. When it takes more than 2 seconds for archive data to be retrieved, adds a label to the plot indicating that the fetch is still in progress so the user knows what is happening.
Requires slaclab/pydm#1319 since it uses those new signals.
Screenshots
Screencast.From.2026-03-13.10-13-51.mp4