Swich to TSK_JAVA_LIB_PATH#8013
Draft
kwizart wants to merge 1 commit intosleuthkit:developfrom
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't claim this is a real fix but It's more an attempt to discuss the expected path).
It seems like autopsy buildsys expects some artefacts in more or less arbitrary locations. This is an attempt to try to understand. In sleuthkit I don't have any indication (IIRC) to where install theses artefacts, but I expect system package to have them in a dedicated TSK_HOME sub-directory. I've choosen this for the sleuthkit package.
TSK_HOME=/usr/share/tsk
Autopsy, then would expect the files to be in:
${TSK_HOME}/binding/java/dist
... for sleuthkit-%{version}.jar
and %{tsk_home}/case-uco/java/dist/
... for sleuthkit-caseuco-%{version}.jar
But then I don't get why they need to be in a separate directories... So I'm using TSK_JAVA_LIB_PATH in order to get the sleuthkit to install them directly in the right directory.
(side note: the sleuthkit in fedora/rhel have been updated to latest, but are still missing the java binding required by autopsy by default).
See also https://koji.fedoraproject.org/koji/packageinfo?packageID=6420