Fix highest/lowest light brightness value resync - #1589
Open
bill876 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to resync the state of brightness by issuing enough commands to go the full range when the highest or lowest value is requested:
Fix reading the length of color temperature list instead of brightness list
Before this change, if the color temps list is smaller than the brightness list, the sync is not achieved. Moreover, it desyncs instead.
For example, let's say the brightness list is [10,20,30,40,50,60,70,80,90,100,200,255] and the color temp list is [2700, 6000]. In this case trying to from brightness 20 to brightness 255 will actually perform 2 steps up, and the light will have the brightness of 40, while the entity state will assume we are at 255.