Skip to content

fix: ignore whitespace-only Disallow paths in extractUrlsFromRobotsTxt #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juliosuas wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −3
Open

fix: ignore whitespace-only Disallow paths in extractUrlsFromRobotsTxt #1973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions spiderfoot/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,8 +931,6 @@ def extractUrlsFromRobotsTxt(robotsTxtData: str) -> typing.List[str]:

Todo:
Check and parse User-Agent.

Fix whitespace parsing; ie, " " is not a valid disallowed path
"""
returnArr: typing.List[str] = list()

Expand All @@ -941,7 +939,11 @@ def extractUrlsFromRobotsTxt(robotsTxtData: str) -> typing.List[str]:

for line in robotsTxtData.splitlines():
if line.lower().startswith('disallow:'):
m = re.match(r'disallow:\s*(.[^ #]*)', line, re.IGNORECASE)
# Use \S to match the first non-whitespace character so that
# "Disallow: " (whitespace-only or empty path) is correctly
# ignored. Previously the pattern used '.' which also matched
# spaces, causing " " to be returned as a disallowed path.
m = re.match(r'disallow:\s*(\S[^ #]*)', line, re.IGNORECASE)
if m:
returnArr.append(m.group(1))

Expand Down